• 0 Posts
  • 76 Comments
Joined 2 years ago
cake
Cake day: July 3rd, 2023

help-circle
  • Code reviews are important. Unfortunately, no-test-text guy convinced his whole team that he was right, and I wasn’t able to block it. I’d scheduled a meeting to try to get the wider org to adopt a more sensible standard, but then there was a mass layoff 🤷

    The other guy with the bad messages is at a tiny startup where they’ve laid off almost everyone, and the other 2 guys don’t want to make waves. The CEO is big on “just ship it” (and also “why are there bugs in production? this is unacceptable!!”)



  • I’ve worked with a few people who are just incomprehensible. One refuses to write commit messages of any detail. Just “work in progress”. Cast him into the pit.

    There was another guy that refused to name his tests. His code was like

    describe(''. () => {
      it('', () => {
         expect(someFunc()).toEqual(0);
      }
     it('', () => {
        expect(someFunc(1)).toEqual(0);
      }
     it('', () => {
       expect(someFunc("").toEqual(1);
     }
    }
    

    He was like, “Test names are like comments and they turn into lies! So I’m not going to do it.”

    I was like, a. what the fuck. b. do you also not name your files? projects? children?

    He was working at a very big company last I heard.

    edit: If you’re unfamiliar, the convention is to put a human readable description where those empty strings are. This is used in the test output. If one fails, it’ll typically tell include the name in the output.












  • I can’t speak for everyone, but for me, in my youth, it helped to actually go out and do the things I was worried about. When I spent all my time home worrying, I just got worse. Once I left the house, went to the party, went on the hike, whatever, I found the reality wasn’t anywhere near what I had worried about





  • Without the plausible threat of action, you will be ignored. Action could be violence (eg: throwing a brick at a cop), or economic (eg: we’re all going to stop working for you, we’re all going to stop spending money at your business). But there needs to be something.

    When it’s just “we meet up for an hour on saturday, sing, and go then home,” that’s just not very effective on its own. You can sing and dance, but there needs to be a backing of “If you don’t treat us well, we can hurt you” if you want to be taken seriously.



  • This doesn’t seem like a good idea.

    One, releasing should be easy. At my last job, you clicked “new release” or whatever on GitHub. It then listed all the commits for you. If you “need” an Ai to summarize the commits, you fucked up earlier. Write better commit messages. Review the changes. Use your brain (something the AI can’t do) to make sure you actually want all of this to go out. Click the button. GitHub runs checks and you’re done.

    Most of the time it took a couple minutes at most to do this process.